[webview_flutter_android] Adds internal wrapper methods for native WebViewClient.
#8964
+6,253
−3,013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
commented
Apr 3, 2025
| @@ -52,6 +52,7 @@ android { | |||
| implementation 'androidx.annotation:annotation:1.9.1' | |||
| implementation 'androidx.webkit:webkit:1.12.1' | |||
| testImplementation 'junit:junit:4.13.2' | |||
| testImplementation 'org.mockito:mockito-core:5.16.1' | |||
There was a problem hiding this comment.
This was required for me to run tests locally. I'm not sure if this is just me or not.
bparrishMines
commented
Apr 3, 2025
| @@ -25,7 +25,7 @@ if (flutterVersionName == null) { | |||
| android { | |||
| namespace 'io.flutter.plugins.webviewflutterexample' | |||
| compileSdk = flutter.compileSdkVersion | |||
|
|
|||
| ndkVersion = flutter.ndkVersion | |||
There was a problem hiding this comment.
This was also required for met to run tests locally.
bparrishMines
changed the title
WebViewClient.
Wrong issue link? That one is about |
stuartmorgan-g
approved these changes
Apr 10, 2025
...utter_android/android/src/main/java/io/flutter/plugins/webviewflutter/ProxyApiRegistrar.java
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/pigeons/android_webkit.dart
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/pigeons/android_webkit.dart
Outdated
Show resolved
Hide resolved
| @@ -513,7 +582,7 @@ abstract class WebChromeClient { | |||
| late List<String> Function( | |||
| WebView webView, | |||
| FileChooserParams params, | |||
| )? onShowFileChooser; | |||
| ) onShowFileChooser; | |||
There was a problem hiding this comment.
Why the change to non-nullable on these callbacks?
There was a problem hiding this comment.
This was caused by #8567. They are already implemented in the AndroidWebViewController: https://github.com/flutter/packages/blob/main/packages/webview_flutter/webview_flutter_android/lib/src/android_webview_controller.dart#L187. The method just wasn't required on the Dart side.
bparrishMines
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the SSL classes for #7893 and a few extra
WebViewClientmethods.Pre-Review Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3