Migrate bootstrapping in element embedding sample (#2315)

Migrating the Angular sample is blocked on flutter/flutter#149443 Contributes to #2297.
flutter · Jun 3, 2024 · 2b451d2 · 2b451d2
1 parent 121d296
commit 2b451d2
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 16 deletions.
diff --git a/web_embedding/element_embedding_demo/pubspec.yaml b/web_embedding/element_embedding_demo/pubspec.yaml
@@ -7,7 +7,6 @@ environment:
   sdk: ^3.4.0-0
 
 dependencies:
-  cupertino_icons: ^1.0.2
   flutter:
     sdk: flutter
 

diff --git a/web_embedding/element_embedding_demo/web/css/style.css b/web_embedding/element_embedding_demo/web/css/style.css
@@ -162,7 +162,7 @@ h1 {
 }
 #flutter_target.resize {
   width: 480px;
-  height: 320px;
+  height: 336px;
 }
 #flutter_target.spin { animation: spin 6400ms ease-in-out infinite; }
 #flutter_target.shadow { position: relative; }

diff --git a/web_embedding/element_embedding_demo/web/index.html b/web_embedding/element_embedding_demo/web/index.html
@@ -20,9 +20,6 @@
     <title>Element embedding</title>
     <link rel="manifest" href="manifest.json" />
 
-    <!-- This script adds the flutter initialization JS code -->
-    <script src="flutter.js" defer></script>
-
     <link rel="stylesheet" type="text/css" href="css/style.css" />
   </head>
   <body>
@@ -81,17 +78,17 @@ <h1>Element embedding</h1>
     </section>
 
     <script>
-      window.addEventListener("load", function (ev) {
-        // Embed flutter into div#flutter_target
-        let target = document.querySelector("#flutter_target");
-        _flutter.loader.loadEntrypoint({
-          onEntrypointLoaded: async function (engineInitializer) {
-            let appRunner = await engineInitializer.initializeEngine({
-              hostElement: target,
-            });
-            await appRunner.runApp();
-          },
-        });
+      {{flutter_js}}
+      {{flutter_build_config}}
+
+      const target = document.getElementById('flutter_target');
+      _flutter.loader.load({
+        onEntrypointLoaded: async function (engineInitializer) {
+          const appRunner = await engineInitializer.initializeEngine({
+            hostElement: target,
+          });
+          await appRunner.runApp();
+        }
       });
     </script>
     <script src="js/demo-js-interop.js" defer></script>

diff --git a/web_embedding/ng-flutter/flutter/web/flutter_bootstrap.js b/web_embedding/ng-flutter/flutter/web/flutter_bootstrap.js