Skip to content

Commit

Permalink
Fixup experimental/federated_plugin (#1776)
Browse files Browse the repository at this point in the history
Replaces #1749

FYI @negotoyolo

## Pre-launch Checklist

- [x] I read the [Flutter Style Guide] _recently_, and have followed its
advice.
- [x] I signed the [CLA].
- [x] I read the [Contributors Guide].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel
channel on [Discord].

<!-- Links -->
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[CLA]: https://cla.developers.google.com/
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Contributors Guide]:
https://github.com/flutter/samples/blob/main/CONTRIBUTING.md
  • Loading branch information
domesticmouse committed May 6, 2023
1 parent ebcf72c commit b703f1f
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 31 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,17 @@ import 'package:flutter_test/flutter_test.dart';
void main() {
group('federated plugin demo tests', () {
const batteryLevel = 45;
setUpAll(() {
const MethodChannel('battery').setMockMethodCallHandler((call) async {
if (call.method == 'getBatteryLevel') {
return batteryLevel;
}
});
});

testWidgets('get current battery level from platform', (tester) async {
tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(
const MethodChannel('battery'),
(call) async {
if (call.method == 'getBatteryLevel') {
return batteryLevel;
}
return 0;
},
);
await tester.pumpWidget(const MyApp());

// Tap button to retrieve current battery level from platform.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,17 @@ void main() {

group('Federated Plugin Test', () {
const batteryLevel = 34;
const MethodChannel('battery').setMockMethodCallHandler((call) async {
if (call.method == 'getBatteryLevel') {
return batteryLevel;
}
});

test('getBatteryLevel method test', () async {
testWidgets('getBatteryLevel method test', (tester) async {
tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(
const MethodChannel('battery'),
(call) async {
if (call.method == 'getBatteryLevel') {
return batteryLevel;
}
return 0;
},
);
final result = await getBatteryLevel();
expect(result, batteryLevel);
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,17 @@ void main() {

group('MethodChannel test', () {
const batteryLevel = 89;
const MethodChannel('battery').setMockMethodCallHandler((call) async {
if (call.method == 'getBatteryLevel') {
return batteryLevel;
}
});

test('getBatteryLevel method test', () async {
testWidgets('getBatteryLevel method test', (tester) async {
tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(
const MethodChannel('battery'),
(call) async {
if (call.method == 'getBatteryLevel') {
return batteryLevel;
}
return 0;
},
);
final locationMethodChannel = BatteryMethodChannel();
final result = await locationMethodChannel.getBatteryLevel();
expect(result, batteryLevel);
Expand Down
9 changes: 3 additions & 6 deletions tool/flutter_ci_script_beta.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,10 @@ declare -ar PROJECT_NAMES=(
"desktop_photo_search/material"
"experimental/context_menus"
"experimental/element_embedding_demo"
# TODO(DomesticMouse): 'setMockMethodCallHandler' is deprecated and shouldn't be used.
# "experimental/federated_plugin/federated_plugin"
# TODO(DomesticMouse): 'setMockMethodCallHandler' is deprecated and shouldn't be used.
# "experimental/federated_plugin/federated_plugin/example"
"experimental/federated_plugin/federated_plugin"
"experimental/federated_plugin/federated_plugin/example"
"experimental/federated_plugin/federated_plugin_macos"
# TODO(DomesticMouse): 'setMockMethodCallHandler' is deprecated and shouldn't be used.
# "experimental/federated_plugin/federated_plugin_platform_interface"
"experimental/federated_plugin/federated_plugin_platform_interface"
"experimental/federated_plugin/federated_plugin_web"
"experimental/federated_plugin/federated_plugin_windows"
"experimental/linting_tool"
Expand Down
9 changes: 3 additions & 6 deletions tool/flutter_ci_script_master.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,10 @@ declare -ar PROJECT_NAMES=(
# TODO(DomesticMouse): The function can't be unconditionally invoked because it can be 'null'.
# "experimental/context_menus"
"experimental/element_embedding_demo"
# TODO(DomesticMouse): 'setMockMethodCallHandler' is deprecated and shouldn't be used.
# "experimental/federated_plugin/federated_plugin"
# TODO(DomesticMouse): 'setMockMethodCallHandler' is deprecated and shouldn't be used.
# "experimental/federated_plugin/federated_plugin/example"
"experimental/federated_plugin/federated_plugin"
"experimental/federated_plugin/federated_plugin/example"
"experimental/federated_plugin/federated_plugin_macos"
# TODO(DomesticMouse): 'setMockMethodCallHandler' is deprecated and shouldn't be used.
# "experimental/federated_plugin/federated_plugin_platform_interface"
"experimental/federated_plugin/federated_plugin_platform_interface"
"experimental/federated_plugin/federated_plugin_web"
"experimental/federated_plugin/federated_plugin_windows"
"experimental/linting_tool"
Expand Down

0 comments on commit b703f1f

Please sign in to comment.