Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecated TextButton to HyperlinkButton #1744

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

miquelbeltran
Copy link
Member

Change the deprecated use of TextButton to HyperlinkButton in fluent_ui sample.

The error was:

Analyzing fluent_ui...

   info - lib/src/widgets/photo_details.dart:40:45 - 'TextButton' is deprecated and shouldn't be used. Deprecated in 4.4.3. Use HypelinkButton instead. Try replacing the use of the deprecated member with the replacement. - deprecated_member_use
   info - lib/src/widgets/photo_details.dart:48:45 - 'TextButton' is deprecated and shouldn't be used. Deprecated in 4.4.3. Use HypelinkButton instead. Try replacing the use of the deprecated member with the replacement. - deprecated_member_use

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@miquelbeltran miquelbeltran changed the title change deprecated TextButton Change deprecated TextButton to HyperlinkButton Apr 24, 2023
@miquelbeltran
Copy link
Member Author

This PR fixes Stable CI. I've seen that this change is also not applied in the beta branch, in case you want to merge it there as well.

@domesticmouse domesticmouse merged commit 9ff21d3 into main Apr 26, 2023
@domesticmouse domesticmouse deleted the mb-fix-fluent_ui-analyze branch April 26, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants