FIX: https://github.com/flutter/samples/issues/1752 and https://githu… #1753
Conversation
|
Thanks for the PR :) Could you also make your changes to the experimental version of this app? https://github.com/flutter/samples/blob/main/experimental/material_3_demo/lib/elevation_screen.dart |
There was a problem hiding this comment.
Hi @rydmike! Thanks a lot for the contribution! Just left one comment below:)
Also sorry if I didn't give a prompt response on other issues. I will work on them one by one!
| ElevationGrid(surfaceTintColor: surfaceTint), | ||
| ElevationGrid( | ||
| surfaceTintColor: surfaceTint, | ||
| shadowColor: Colors.transparent, |
There was a problem hiding this comment.
Edited: Originally I wanted to compare: (1) only setting surface tint color v.s. (2) setting both v.s. (3) only setting shadow color. But it might look confusing because the first two rows are identical when shadow color is null. Sorry about that!
I'm thinking, instead of setting this shadow color to be transparent, maybe we can set a different shadow color, such as colorScheme.primary, so that we can see the difference easily.
There was a problem hiding this comment.
Just gave it another thought. I think setting it to transparent is a better way to only show the surface tint color. So LGTM! I can make the same change to the experimental one.
There was a problem hiding this comment.
@QuncCccccc yes I agree, since the idea is to demonstrate normal shadow+tint and only tint based elevations.
Originally this screen looked as I made it look again, the tint only row, had no shadows. Later a change in the framework of how Material behaves in M3 mode, broke the original design. This brings back the original intent to present the different forms of elevation possibilities in Material 3.
| ElevationGrid(surfaceTintColor: surfaceTint), | ||
| ElevationGrid( | ||
| surfaceTintColor: surfaceTint, | ||
| shadowColor: Colors.transparent, |
There was a problem hiding this comment.
Just gave it another thought. I think setting it to transparent is a better way to only show the surface tint color. So LGTM! I can make the same change to the experimental one.
|
@parlough Sure I will update the PR to include the same fixes to the experimental version too. EDIT: Done |
Apply FIX for: FIX: flutter#1751 FIX: flutter#1752 to experimental version of material_3_demo
|
@QuncCccccc can you please re-review for the changes to the |
|
@rydmike can you please bring this PR up to date with |
…b.com//issues/1751
Fixes for:
The screen that shows Material elevation and row that says "Surface Tint Color Only" has shadow and shown elevation dp is wrong.
FIX: #1751
FIX: #1752
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.