Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish web_embedding #1777

Merged
merged 1 commit into from
May 6, 2023
Merged

Publish web_embedding #1777

merged 1 commit into from
May 6, 2023

Conversation

domesticmouse
Copy link
Contributor

@domesticmouse domesticmouse commented May 5, 2023

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Co-authored-by: Mark Thompson [email protected]
Co-authored-by: David Iglesias [email protected]

@domesticmouse domesticmouse requested a review from ditman May 5, 2023 23:55
Move web_embedding samples out of 'experimental'.
Publishes new Flutter web on Angular sample.

Co-authored-by: Mark Thompson <[email protected]>
Co-authored-by: David Iglesias <[email protected]>
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's go!

@domesticmouse
Copy link
Contributor Author

I'll land once CI turns (mostly) green. =)

@domesticmouse domesticmouse merged commit 91cb685 into flutter:main May 6, 2023
@domesticmouse domesticmouse deleted the publish-web_embedding branch May 6, 2023 00:53
@ditman
Copy link
Member

ditman commented May 6, 2023

Thanks Brett!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants