Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Gen UI demo #1778

Merged
merged 11 commits into from
May 17, 2023
Merged

Next Gen UI demo #1778

merged 11 commits into from
May 17, 2023

Conversation

domesticmouse
Copy link
Contributor

First pass at a Next Generation UI demo app. The UI needs work, feedback gratefully accepted.

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@domesticmouse domesticmouse changed the title Next-gen-ui-demo Next Gen UI demo May 7, 2023
@domesticmouse
Copy link
Contributor Author

PTAL @craiglabenz

Copy link
Contributor

@craiglabenz craiglabenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to LGTM this because it's very good. My only nit, which I of course consider optional given the LGTM, is to show some sort of progress indicator - which could be as simple as a fraction (e.g., "Step 1 / 10", or what have you).

@domesticmouse
Copy link
Contributor Author

Going to LGTM this because it's very good. My only nit, which I of course consider optional given the LGTM, is to show some sort of progress indicator - which could be as simple as a fraction (e.g., "Step 1 / 10", or what have you).

Screenshot 2023-05-17 at 12 03 07 pm

@domesticmouse domesticmouse merged commit aec29f8 into flutter:main May 17, 2023
@domesticmouse domesticmouse deleted the next-gen-ui-demo branch May 17, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants