-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding more named and explicit imports #1909
adding more named and explicit imports #1909
Conversation
I'm wondering if we should just adopt the default of |
Also, please update this PR to turn the CI green. =) |
makes sense, I will do the change to see how it looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is import 'dart:math' as math;
something we do elsewhere? It almost feels like overkill?
As with the other changes we have done related to flutter/website#7798 none of them are strictly necessary. I like the idea of having the math dependency as a named import because it allows for easier discoverability, and because the math import has a lot of top level functions and constants, so it doesn't mess with autocomplete. Although, effective Dart doesn't have a recommendation regarding this, and I don't have a strong opinion on this either, so I'm fine to revert the change. |
Following the proposal in flutter/website#7798 I have added more explicit and named imports on those places I thought it would make sense.
Let me know what you think.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.