Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index of platform vulnerabilities that Flutter developers should be aware of #11829

Closed
wants to merge 1 commit into from

Conversation

ash2moon
Copy link

@ash2moon ash2moon commented Mar 18, 2025

Adds documentation for an Android specific vulnerability (StrandHogg in a new index of platform-specific vulnerabilities.

Resolves #11828

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@ash2moon ash2moon requested review from sfshaza2, antfitch, parlough and a team as code owners March 18, 2025 00:03
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Mar 18, 2025

Visit the preview URL for this PR (updated for commit d71ecd6):

https://flutter-docs-prod--pr11829-main-6ppfucvy.web.app

@parlough parlough changed the title add Platform Vulnerabilities documentation Add index of platform vulnerabilities that Flutter developers should be aware of Mar 18, 2025
@parlough parlough requested review from jmagman and reidbaker March 18, 2025 18:50
@jmagman
Copy link
Member

jmagman commented Mar 19, 2025

My gut here is that we shouldn't be directly documenting platform issues that aren't Flutter specific, but instead link to external resources where it makes sense. Our own version will be very incomplete and likely out-of-date.
I think targeted warnings in the tool are more effective (flutter/flutter#144484) where we can directly make an actionable suggestion (raise your min SDK).

I'd love to hear @sfshaza2 opinion though.

(and sorry @ash2moon I know this one looked like an easy one to pick off, my bad)

@sfshaza2
Copy link
Contributor

sfshaza2 commented Mar 19, 2025

I agree with @jmagman, 100%. If there's a place in the Android docs that lists these things, I'd be happy to link to it. Perhaps a new, but short, page here: https://docs.flutter.dev/platform-integration/android

But, we don't have the resources to keep something like this up to date.

@sfshaza2 sfshaza2 closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that older Android versions have unmitigatable security risks on our supported platforms page
5 participants