Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property to feedback widget to capture page location. #11837

Closed
wants to merge 1 commit into from

Conversation

antfitch
Copy link
Contributor

Description of what this PR is changing or adding, and why:

We want developers to be able to rate our pages. We can do this now, but we're not capturing the page location that they want to rate. Added an additional parameter to our event tag to capture this.

@RedBrogdon are you able to take a quick look?

Issues fixed by this PR (if any):

PRs or commits this PR depends on (if any):

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

Sorry, something went wrong.

@antfitch antfitch requested review from sfshaza2, parlough and a team as code owners March 20, 2025 17:11
@antfitch antfitch requested a review from RedBrogdon March 20, 2025 17:11
@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 3584a2d):

https://flutter-docs-prod--pr11837-analytics-add-properties-knkib2nw.web.app

@antfitch
Copy link
Contributor Author

Never mind. I don't think we need this field.

@antfitch antfitch closed this Mar 20, 2025
@antfitch
Copy link
Contributor Author

Actually, I think we might need this. Can someone review?

@antfitch antfitch reopened this Mar 20, 2025
@antfitch antfitch closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants