Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pub publish dry run, set up dependabot #27

Merged
merged 6 commits into from
Aug 27, 2023
Merged

Conversation

nohli
Copy link
Collaborator

@nohli nohli commented Aug 27, 2023

No description provided.

@nohli nohli requested a review from AlexV525 August 27, 2023 12:18
@nohli
Copy link
Collaborator Author

nohli commented Aug 27, 2023

Why is using master preferred?

I think, with the mock credentials, the actions doesn't work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I'd prefer to update pub dependencies only when in major/minor updates, there should be no need to follow patches.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config is ignoring minor and patch updates for pub dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's great

@AlexV525
Copy link
Member

Why is using master preferred?

This is suggested by the author in one of his comments, I cannot find it at present,

I think, with the mock credentials, the actions doesn't work.

Actually this will work because if you're developing on forks, their repo would not contain an actual credential, and a dry-run does not require a valid credential.

@nohli
Copy link
Collaborator Author

nohli commented Aug 27, 2023

Why is using master preferred?

This is suggested by the author in one of his comments, I cannot find it at present,

I'm using v1.6 for my packages, and it works well (accidentally just pushed 1.6 without the v).
Thought, it's safer than master, plus I've added dependabot, so it got updated.

I think, with the mock credentials, the actions doesn't work.

Actually this will work because if you're developing on forks, their repo would not contain an actual credential, and a dry-run does not require a valid credential.

That's true. I assumed, that was the reason why the dry run fails at main. Looks like it works with the mock credentials, good to know.

@nohli nohli merged commit 5a1e5dc into main Aug 27, 2023
1 check passed
@nohli nohli deleted the update-workflows branch August 27, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants