Feature/post content #27
Open
+583
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
emmanuelCode
commented
Jan 11, 2024
•
emmanuelCode
commented
- added Image picker to take picture from camera and select picture from the gallery
- fixed issues with running emulator on a android device
- update all dependencies
- setup firebase cloud storage
- upload image to storage reference (prototype)
- update instruction in readme
- add translation in arb files
- add unit test
- add widget test
emmanuelCode
requested review from
leehack and
billyandco
and removed request for
a team
Open
leehack
reviewed
Jan 15, 2024
Comment on lines
+26
to
+34
| 4. Connect your Android device with Firebase Emulator Servers: | ||
|
|
||
| Firestore | ||
| ```bash | ||
| adb reverse tcp:8080 tcp:8080 | ||
| ``` | ||
| Storage | ||
| ```bash | ||
| adb reverse tcp:9199 tcp:9199 |
There was a problem hiding this comment.
Normally it should be required since it is supposed to be automatic.
leehack
reviewed
Jan 15, 2024
README.md
Outdated
|
|
||
| ### How to initialize Firebase | ||
| ### How to initialize Firebase Production |
There was a problem hiding this comment.
I'm not sure if it's instruction for production. It's just a general instruction.
leehack
reviewed
Jan 15, 2024
README.md
Outdated
Comment on lines
71
to
85
| 7. Disable the firebase emulator dev environment | ||
|
|
||
| **disable the following lines of codes in `lib/main.dart` or build in production mode** | ||
| ```dart | ||
| if (kDebugMode) { | ||
| try { | ||
| const host = '0.0.0.0'; | ||
| FirebaseStorage.instance.useStorageEmulator(host, 9199); | ||
| FirebaseFirestore.instance.useFirestoreEmulator(host, 8080); | ||
| } catch (e) { | ||
| // ignore: avoid_print | ||
| print(e); | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
This isn't required since there's the kDebugMode, it's not mandatory change. It's only required when the dev wants to test their debug build against to firebase server rather than the emulator.
leehack
reviewed
Jan 15, 2024
README.md
Outdated
|
|
||
| ## Support | ||
|
|
||
| If you have trouble running this project. Go to our [discord group](https://discord.gg/NMc62wG7eU) and ask your questions under #stackoverflow channel. We'll be happy to lend you a hand. |
There was a problem hiding this comment.
I think we'd better encourage users to create a ticket in GitHub rather than Discord. (That doesn't mean they can't tho..)
leehack
reviewed
Jan 15, 2024
firebase.json
Outdated
| @@ -1,15 +1,23 @@ | |||
| { | |||
| "emulators": { | |||
| "firestore": { | |||
| "port": 8080 | |||
| "port": 8080, | |||
| "host": "0.0.0.0" | |||
leehack
reviewed
Jan 15, 2024
firebase.json
Outdated
| "singleProjectMode": true, | ||
| "storage": { | ||
| "port": 9199, | ||
| "host": "0.0.0.0" |
leehack
reviewed
Jan 15, 2024
lib/main.dart
Outdated
Comment on lines
20
to
22
| const host = '0.0.0.0'; | ||
| FirebaseStorage.instance.useStorageEmulator(host, 9199); | ||
| FirebaseFirestore.instance.useFirestoreEmulator(host, 8080); |
There was a problem hiding this comment.
I don't think we need this change.
leehack
reviewed
Jan 15, 2024
| import 'package:image_picker/image_picker.dart'; | ||
| import 'package:instreal/features/posts/post_entity.dart'; | ||
|
|
||
| import '../../../l10n/index.dart'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.