Move highlighting and constraints from 'Shape Configuration' popover to new 'Shaper Extra' popover

[anesthetice]

fixes #1504

Two things left to iron out:

1. is "Shaper Extra" the best way to describe what the new popover contains?
2. padding seems a little short between end of 'Highlighting' and 'Constraints'

[anesthetice]

[Doublonmousse]

What about a simple

Shape Configuration (2/2)

and adding a (1/2) on the first page.

Though at that point a next/previous page navigation makes more sense.

Maybe a nagivation view can work inside of the popover ? https://gnome.pages.gitlab.gnome.org/libadwaita/doc/1.7/class.NavigationView.html

[anesthetice]

@Doublonmousse Thanks for taking the time to review this PR, I'll try to work on it later today, I think naming the new popup Shape Configuration (2/2) is better than the current Shaper Extra, but still feels a little off, as it wouldn't be clear why these two were made separate...

What do you think about renaming what is currently called Shape Configuration to Shape Styling (and re-using the previous icon that changes depending on whether the Smooth or Rough style is enabled); and instead of Shaper Extra just Shaper Configuration?

As for implementing next/previous page navigation, I'm not in favor, as that would increase the steps needed to change something.

[Doublonmousse]

@Doublonmousse Thanks for taking the time to review this PR, I'll try to work on it later today, I think naming the new popup Shape Configuration (2/2) is better than the current Shaper Extra, but still feels a little off, as it wouldn't be clear why these two were made separate...

What do you think about renaming what is currently called Shape Configuration to Shape Styling (and re-using the previous icon that changes depending on whether the Smooth or Rough style is enabled); and instead of Shaper Extra just Shaper Configuration?

Then the gear icon would be used for the second panel I guess.
Yes that makes sense and it's also a little more coherent/useful that what we have now (so we know both the shape and the style mode)

As for implementing next/previous page navigation, I'm not in favor, as that would increase the steps needed to change something.

I would have kept the two buttons but added one to switch from one popup to the other. Although after the change of icon it's not needed anymore because you'd know where to click in the first place