Skip to content

Improve showing why a line was shown in deployment log#481

Merged
zagy merged 25 commits intomainfrom
better-logging-reasons
Jun 23, 2025
Merged

Improve showing why a line was shown in deployment log#481
zagy merged 25 commits intomainfrom
better-logging-reasons

Conversation

@elikoga
Copy link
Copy Markdown
Member

@elikoga elikoga commented Nov 11, 2024

Solves #474

If line is shown because Component is eligible to update:
localhost > SensitiveValues > File('work/sensitivevalues/client_ed25519.key') > Content('client_ed25519.key'): update

If line is shown because Component took too long to evaluate:
localhost > Takeslongtime [total=...s, verify=...s, update=NaN, sub=NaN] verify took too long

@elikoga elikoga marked this pull request as ready for review November 11, 2024 10:39
@elikoga elikoga requested a review from zagy as a code owner November 11, 2024 10:39
@zagy zagy self-assigned this Nov 11, 2024
@zagy zagy force-pushed the better-logging-reasons branch from 70f0825 to 659fc10 Compare December 16, 2024 07:11
@zagy zagy assigned elikoga and unassigned zagy May 14, 2025
@elikoga
Copy link
Copy Markdown
Member Author

elikoga commented May 23, 2025

For output.annotate I disabled indenting the lines as if an invisible icon was there due to it being distracting in some outputs such as diffs.
I believe that emojis delimitating sections in the Terminal output are visual enough indicators and do not need a new added indentation layer

@elikoga elikoga force-pushed the better-logging-reasons branch from 4b61313 to 64d126e Compare May 23, 2025 12:30
@elikoga
Copy link
Copy Markdown
Member Author

elikoga commented May 23, 2025

Rebased on top of #510 for ease when replacing messages

@elikoga elikoga force-pushed the better-logging-reasons branch from 64d126e to 8c054cb Compare June 16, 2025 11:11
@zagy zagy merged commit 62883b6 into main Jun 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants