Updating of artifacts and artifact data

[MorpheusXAUT]

TL;DR

This PR extends datacatalog to support the updating of artifacts and overwriting of stored artifact data as well as some minor cleanup/housekeeping.

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

The new UpdateArtifact endpoints allows for an existing artifact to be updated. At the moment, only the underlying ArtifactData can be overwritten.
While updating, datacatalog will create any new data keys, overwrite any existing ones with the new data provided and remove no longer provided elements from the underlying blob storage. To facilitate a full cleanup, deletion of artifact data was implemented as well.

This PR also fixes the mock generation for the repository interfaces as they seem to have never been re-generated using the latest mockery version.
Additionally, the datacatalog project was moved to Go 1.18 and the Dockerfile setup was adapted to be in line with flyteadmin. Some minor cleanup/housekeeping was performed to make the linter happy.

As this uses a currently unmerged flyteidl version, the PR is created as a draft (for review) until a new version of flyteidl is available.

Tracking Issue

flyteorg/flyte#2867

Follow-up issue

NA

[codecov]

Codecov Report

Merging #83 (995f5e3) into master (42c55c9) will increase coverage by 0.84%.
The diff coverage is 71.72%.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   68.70%   69.54%   +0.84%     
==========================================
  Files          31       31              
  Lines        1262     1376     +114     
==========================================
+ Hits          867      957      +90     
- Misses        325      341      +16     
- Partials       70       78       +8     

Flag	Coverage Δ
unittests	68.45% <70.07%> (+0.82%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/manager/impl/artifact_data_store.go	68.00% <50.00%> (-3.43%)	⬇️
pkg/manager/impl/artifact_manager.go	70.23% <68.57%> (+3.38%)	⬆️
pkg/repositories/gormimpl/artifact.go	84.37% <83.33%> (-0.63%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[welcome]

Thank you for opening this pull request! 🙌
These tips will help get your PR across the finish line: - Most of the repos have a PR template; if not, fill it out to the best of your knowledge. - Sign off your commits (Reference: DCO Guide).

[hamersaw]

Is there any reason we changed this from using a switch over to len(queryHandle.GetArtifcatId()) from request.QueryHandle.(type). Was it required because of the addition of UpdateArtifactRequest handling?

[MorpheusXAUT]

@hamersaw Yes, exactly. Unfortunately the type generated for the UpdateArtifactRequest is a datacatalog.UpdateArtifactRequest_ArtifactId (instead of a datacatalog.GetArtifactRequest_ArtifactId), however both implement GetArtifactId() string.
As the oneof interface is not exported in the generated protobuf definitions, we can't use a shared interface, so this new artifactQueryHandle interface was the easiest I came up with (which allows both to be passed as a single method parameter).

[welcome]

Congrats on merging your first pull request! 🎉