Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent Get Pending Message #4106

Merged
merged 8 commits into from
Oct 10, 2023

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Sep 30, 2023

Description.

Two months ago, I introduced the Databricks agent service.
Currently, job statuses progress from "pending" to "running" to "succeeded".
To enhance user experience, @pingsutw, @kumare3, and I propose enriching the "pending" status with additional information for Databricks API and future implementations.
This update will relay detailed messages to the Flyte console to keep users informed.

Checks

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

image
image

image

Follow-up issue

#4115
flyteorg/flytekit#1834
#3936

Signed-off-by: Future Outlier <[email protected]>
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4ee73f5) 59.44% compared to head (8e319a2) 59.90%.
Report is 1 commits behind head on master.

❗ Current head 8e319a2 differs from pull request most recent head 16dac19. Consider uploading reports for the commit 16dac19 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4106      +/-   ##
==========================================
+ Coverage   59.44%   59.90%   +0.46%     
==========================================
  Files         637      568      -69     
  Lines       54262    40945   -13317     
==========================================
- Hits        32254    24527    -7727     
+ Misses      19467    14041    -5426     
+ Partials     2541     2377     -164     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lyteplugins/go/tasks/pluginmachinery/core/phase.go 21.50% <ø> (-1.27%) ⬇️
...yteplugins/go/tasks/plugins/webapi/agent/plugin.go 71.82% <100.00%> (+5.92%) ⬆️

... and 572 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Future Outlier added 7 commits October 2, 2023 17:18
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
@eapolinario eapolinario merged commit 4717c8d into flyteorg:master Oct 10, 2023
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants