Skip to content

Conversation

zhenyu
Copy link

@zhenyu zhenyu commented Jun 24, 2025

Tracking issue

Why are the changes needed?

#6395 CI failed because of the assertContainerHasPTrace is not necessary since the ptrace was moved to sidercar.

What changes were proposed in this pull request?

remove the assertContainerHasPTrace

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:
.- fixed: For any bug fixed.

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

welcome bot commented Jun 24, 2025

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

Copy link

codecov bot commented Jul 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.88%. Comparing base (d99aad9) to head (7cd16c2).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           container-task-ptrace    #6508   +/-   ##
======================================================
  Coverage                  57.88%   57.88%           
======================================================
  Files                        774      774           
  Lines                      57337    57337           
======================================================
  Hits                       33189    33189           
  Misses                     21651    21651           
  Partials                    2497     2497           
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.28% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 64.70% <ø> (ø)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flytepropeller 54.79% <ø> (ø)
unittests-flytestdlib 64.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants