Skip to content

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Aug 22, 2025

  • Add flyteidl and minimal publishing workflows

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

* Add flyteidl and minimal publishing workflows

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* pretend version for buf python

Signed-off-by: Haytham Abuelfutuh <[email protected]>

---------

Signed-off-by: Haytham Abuelfutuh <[email protected]>
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

* python version fix and use OIDC to authenticate crates

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix python versioning

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Set version before setting up env

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* echo version

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Write to GITHUB_ENV

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Use env:

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* buf generate

Signed-off-by: Haytham Abuelfutuh <[email protected]>

---------

Signed-off-by: Haytham Abuelfutuh <[email protected]>
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

Signed-off-by: Haytham Abuelfutuh <[email protected]>
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

* Mark go package as /v2 to be able to import both at the same time

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Upgrade to go 1.24

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Rename python, rust and npm to flyteidl2

Signed-off-by: Haytham Abuelfutuh <[email protected]>

---------

Signed-off-by: Haytham Abuelfutuh <[email protected]>
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

…6610)

* trying idl2

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update trace def

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* refactor: rename idl2 to flyteidl2

Signed-off-by: machichima <[email protected]>

* generate -> buf

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* refactor: rename idl2 to flyteidl2

Signed-off-by: machichima <[email protected]>

* build: re-gen

Signed-off-by: machichima <[email protected]>

* fix: exclude python venv

Signed-off-by: machichima <[email protected]>

* Add translator service

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Regen

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* buf gen

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* refactor

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* remove node execution service proto

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Breakup task service into a separate package

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Help strings for make file targets

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update TaskLog with read bool

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Trying the updated protovalidate plugin

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* protovalidate with semver

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* try claude :shrug

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* add buf

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* update

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* update deps

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* build: remove generate validate for python

Signed-off-by: machichima <[email protected]>

* build: use managed mode on buf.gen.yaml

Signed-off-by: machichima <[email protected]>

* Update validate go plugin

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update imagebuild

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix oneof buf lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Add deps to generated python code

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Be explicit about the index

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* updated idl

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Catch up to main

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Generate mocks for workflow package

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* generate mocks for other packages

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* buf improvements

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* updates

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* feat: generate mock for common

Signed-off-by: machichima <[email protected]>

* use make gen in GH Actions

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Do not setup python env in generation CI

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* setup uv

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* set working directory

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Try to reference files by path

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Explicitly move .venv to root

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* try exclude in buf.yaml

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* set UV_PROJECT_ENVIRONMENT

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* download tooling

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* add which mockery

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

---------

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: machichima <[email protected]>
Co-authored-by: machichima <[email protected]>
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants