Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Detailed sendgrid email error logging #503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

katrogan
Copy link
Contributor

Signed-off-by: Katrina Rogan [email protected]

TL;DR

Verbose email logging on sendgrid failures

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Tracking Issue

fixes flyteorg/flyte#3150

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #503 (77e25c5) into master (a1804d5) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
- Coverage   60.52%   60.50%   -0.02%     
==========================================
  Files         163      163              
  Lines       14492    14496       +4     
==========================================
  Hits         8771     8771              
- Misses       4955     4959       +4     
  Partials      766      766              
Flag Coverage Δ
unittests 60.50% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../notifications/implementations/sendgrid_emailer.go 67.92% <0.00%> (-5.55%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant