This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Implement GetFlyteKitMetrics endpoint #575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yicheng-Lu-llll <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Yicheng-Lu-llll
changed the title
Yicheng-Lu-llll
requested review from
katrogan,
wild-endeavor,
EngHabu,
kumare3,
pmahindrakar-oss,
hamersaw and
eapolinario
as code owners
Signed-off-by: Yicheng-Lu-llll <[email protected]>
This was referenced Jun 24, 2023
Yicheng-Lu-llll
commented
Jun 24, 2023
| return nil, err | ||
| } | ||
|
|
||
| blob, err := m.urlData.Get(ctx, nodeExecution.Closure.SpanUri) |
There was a problem hiding this comment.
TODO: m.urlData.Get generates the signed URL. We may not need it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This is part of Flytekit Metrics Exploration.
This PR Implements GetFlyteKitMetrics endpoint(also highlighted in green):
Checks
/api/v1/metrics/node_executions/{id.execution_id.project}/{id.execution_id.domain}/{id.execution_id.name}/{id.node_id}
Flytekit Metrics Exploration includes:
flytekit: Upload Flytekit runtime metrics to S3 flytekit#1683
flyteplugins: Add GetSpanPath and SpanExists flyteplugins#361
flyteidl: Add span uri flyteidl#415
flytepropeller: Add span uri to node event flytepropeller#577
flyteadmin: Implement GetFlyteKitMetrics endpoint #575