-
Notifications
You must be signed in to change notification settings - Fork 62
Conversation
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
+ Coverage 58.68% 59.78% +1.10%
==========================================
Files 171 171
Lines 16484 13444 -3040
==========================================
- Hits 9674 8038 -1636
+ Misses 5958 4552 -1406
- Partials 852 854 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw will this work without any managed AWS services like SNS, i.e. also on other cloud providers like GCP? |
@fg91, we'll support GCP pub/sub. We'd like to add Redis or Kafka publisher for the on-prem cluster but in separate PR. |
This is awesome, thanks 🙏 |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
When using this new feature to send notifications to slack via webhooks (instead of via emails), how will the UX look like in flytekit in the end? wacky_int_doubler_lp = LaunchPlan.get_or_create(
notifications=[
Slack(
phases=[
WorkflowExecutionPhase.SUCCEEDED,
],
recipients_email=["[email protected]"], # What will this be replaced with?
),
],
) (Source) Will there be the option to choose a specific webhook, e.g. via name (which in the end corresponds to a Slack channel if I understand correctly)? |
Signed-off-by: Kevin Su <[email protected]>
Something like this. lp = LaunchPlan.get_or_create(
notifications=[
Webhook(
name=<webhook_name>, # Should match the name in Flyte admin config map.
phases=[
WorkflowExecutionPhase.SUCCEEDED,
],
payload=["{{ name succeeded }}"],
),
],
) In the current implementation, the admin will call the webhook endpoint when the task is completed. |
Signed-off-by: Kevin Su <[email protected]>
This sounds great 👍 |
Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to flyteorg/flyte#4147. Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components. |
TL;DR
Add a new webhook processor capable of parsing the workflow event and sending the message to an external service, such as Slack.
SNS
Type
Are all requirements met?
Complete description
webhook config
Tracking Issue
flyteorg/flyte#2317
Follow-up issue
NA