Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Run optimized p0 tests #592

Closed
wants to merge 4 commits into from
Closed

Conversation

eapolinario
Copy link
Contributor

TL;DR

Run optimized P0 test suite and also non-P0 tests

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: eduardo apolinario <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
@eapolinario eapolinario reopened this Jul 25, 2023
@eapolinario
Copy link
Contributor Author

Why aren't tests running?

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #592 (b4bdd0d) into master (248e947) will increase coverage by 1.45%.
The diff coverage is n/a.

❗ Current head b4bdd0d differs from pull request most recent head 972edbd. Consider uploading reports for the commit 972edbd to get more accurate results

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
+ Coverage   58.74%   60.19%   +1.45%     
==========================================
  Files         168      168              
  Lines       16307    13326    -2981     
==========================================
- Hits         9579     8022    -1557     
+ Misses       5878     4454    -1424     
  Partials      850      850              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 155 files with indirect coverage changes

Signed-off-by: eduardo apolinario <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
@eapolinario
Copy link
Contributor Author

will incorporate those changes to boilerplate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant