-
Notifications
You must be signed in to change notification settings - Fork 62
Implement Sandbox notifications processor and publisher #595
Implement Sandbox notifications processor and publisher #595
Conversation
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: eapolinario <[email protected]> Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]> Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
8c9e1ca
to
c4a0fcf
Compare
Signed-off-by: Future Outlier <[email protected]>
…ture-Outlier/flyteadmin into first-version-email-publihser
Signed-off-by: Future Outlier <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
+ Coverage 58.42% 60.26% +1.84%
==========================================
Files 168 170 +2
Lines 16393 13433 -2960
==========================================
- Hits 9578 8096 -1482
+ Misses 5964 4486 -1478
Partials 851 851
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…dbox_processor_test.go Signed-off-by: Future Outlier <[email protected]>
@pingsutw I've updated my test, please check it. |
I am not pretty sure whether use a noop emailer or a mock emailer, please get in touch with me if it is necessary to change the code. |
Signed-off-by: Future Outlier <[email protected]>
BTW, I just copy the master branch's go.mod and go.sum to my branch currently and run "go mod tidy" |
pkg/async/notifications/implementations/sandbox_publisher_test.go
Outdated
Show resolved
Hide resolved
pkg/async/notifications/implementations/sandbox_processor_test.go
Outdated
Show resolved
Hide resolved
…in factory_test.go Signed-off-by: Future Outlier <[email protected]>
…sting Signed-off-by: Future Outlier <[email protected]>
c05a78c
pkg/async/notifications/implementations/sandbox_processor_test.go
Outdated
Show resolved
Hide resolved
…name both of them Signed-off-by: Future Outlier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. This is failing the code coverage check, but I think the code cov annotations have suggestions for some additional test cases we could use to bump the code coverage on this PR and so that we can test more scenarios
Thanks for the suggestions, I've learned a lot! |
…de coverage Signed-off-by: Future Outlier <[email protected]>
…or adn publisher Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding all the unit tests!
TL;DR
Implement notifications processor and publisher for Sandbox.
Type
Are all requirements met?
Complete description
Add new SandboxProcessor and SandboxPublisher that implement the Processor interface.
I add config in yaml file like this
screenshot
![image](https://private-user-images.githubusercontent.com/76461262/256572446-00c0bc6c-38b0-4c58-aa9c-000eeecc6484.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5Mzk5MzIsIm5iZiI6MTcyNTkzOTYzMiwicGF0aCI6Ii83NjQ2MTI2Mi8yNTY1NzI0NDYtMDBjMGJjNmMtMzhiMC00YzU4LWFhOWMtMDAwZWVlY2M2NDg0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDAzNDAzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI5M2NjNzc5MmRlYmRlOTFhYTJiYWE5OTZhZWMyZDczNGYxZGIwMzFmMDMxODk2YWE5ZGFkZjUxMzJhNTEyZDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.g3s0mtUXLt_vjFMqbdiKNqtD1Op7tmhc1lqLcJtybHU)
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/