This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
- #607
Closed
- #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iaroslav-ciupin
commented
Aug 28, 2023
•
iaroslav-ciupin
commented
Signed-off-by: Iaroslav Ciupin <[email protected]>
iaroslav-ciupin
requested review from
katrogan,
wild-endeavor,
EngHabu,
kumare3,
pmahindrakar-oss,
hamersaw and
eapolinario
as code owners
katrogan
reviewed
Aug 28, 2023
| @@ -120,6 +120,54 @@ func prepareValues(field string, values []string) (interface{}, error) { | |||
| return preparedValues, nil | |||
| } | |||
|
|
|||
| var allowedJoinTableColumns = map[common.Entity]map[common.Entity]sets.String{ | |||
| common.Execution: { | |||
| common.Execution: gormimpl.ExecutionColumns, | |||
There was a problem hiding this comment.
instead of duplicating the mapping between common.Entity -> allowedcolumns, can we create two sets here?
- for entity -> allowed join entities
- for entity -> allowed columns
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
==========================================
+ Coverage 58.72% 60.31% +1.59%
==========================================
Files 171 171
Lines 16484 13475 -3009
==========================================
- Hits 9680 8128 -1552
+ Misses 5952 4494 -1458
- Partials 852 853 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.