Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Expire flyte_idt cookie at logout #610

Merged
merged 7 commits into from
Sep 11, 2023
Merged

Conversation

iaroslav-ciupin
Copy link
Contributor

@iaroslav-ciupin iaroslav-ciupin commented Sep 6, 2023

TL;DR

As discussed with @EngHabu, we need to expire flyte_idt cookie containing ID token as well during the logout.
Also, I've run make update_boilerplate.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Iaroslav Ciupin <[email protected]>
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.63% 🎉

Comparison is base (6f49854) 58.86% compared to head (76ed7ac) 60.49%.

❗ Current head 76ed7ac differs from pull request most recent head 3579697. Consider uploading reports for the commit 3579697 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #610      +/-   ##
==========================================
+ Coverage   58.86%   60.49%   +1.63%     
==========================================
  Files         171      171              
  Lines       16468    13435    -3033     
==========================================
- Hits         9694     8128    -1566     
+ Misses       5926     4457    -1469     
- Partials      848      850       +2     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
auth/cookie_manager.go 72.64% <100.00%> (+11.04%) ⬆️

... and 157 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Iaroslav Ciupin <[email protected]>
katrogan
katrogan previously approved these changes Sep 6, 2023
EngHabu
EngHabu previously approved these changes Sep 6, 2023
Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: Iaroslav Ciupin <[email protected]>
Signed-off-by: Iaroslav Ciupin <[email protected]>
Signed-off-by: Iaroslav Ciupin <[email protected]>
Signed-off-by: Iaroslav Ciupin <[email protected]>
Signed-off-by: Iaroslav Ciupin <[email protected]>
@iaroslav-ciupin iaroslav-ciupin merged commit b32a3d3 into master Sep 11, 2023
14 checks passed
@iaroslav-ciupin iaroslav-ciupin deleted the logout-expire-idt-cookie branch September 11, 2023 17:44
eapolinario pushed a commit that referenced this pull request Sep 28, 2023
* Expire flyte_idt cookie at logout
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants