FlyteAdmin will always add base_exec_id unless it is already added
#616
Conversation
Reasons: 1. Make it possible to retrieve all executions launched by the same base execution id (even recursively) 2. users could group executions using their own base exec id 3. flytectl get executions or remote list executions can use this label as a filter to retrieve high level progress of all subworkflows Signed-off-by: Ketan Umare <[email protected]>
kumare3
requested review from
katrogan,
wild-endeavor,
EngHabu,
pmahindrakar-oss,
hamersaw and
eapolinario
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #616 +/- ##
==========================================
+ Coverage 59.01% 60.57% +1.56%
==========================================
Files 171 171
Lines 16468 13450 -3018
==========================================
- Hits 9719 8148 -1571
+ Misses 5899 4451 -1448
- Partials 850 851 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Ketan Umare <[email protected]>
wild-endeavor
changed the title
base_exec_id unless it is already addedbase_exec_id unless it is already added
|
This isn't a minor change right? |
| @@ -1687,6 +1690,19 @@ func (m *ExecutionManager) addProjectLabels(ctx context.Context, projectName str | |||
| return initialLabels, nil | |||
| } | |||
|
|
|||
| // Adds base execution label to execution labels. Base execution label is ignored if a corresponding label is set on the execution already. | |||
There was a problem hiding this comment.
| // Adds base execution label to execution labels. Base execution label is ignored if a corresponding label is set on the execution already. | |
| // addBaseExecutionLabel adds base execution label to execution labels. Base execution label is ignored if a corresponding label is set on the execution already. |
| WorkflowClosure = "workflow_closure" | ||
| ParentID = "parent_id" | ||
| WorkflowClosure = "workflow_closure" | ||
| BaseExecutionIDLabelKey = "base_exec_id" |
There was a problem hiding this comment.
Should we call it parent_exec_id? just to keep names consistent... I understand that for "self" execution that will sound weird... 🤷🏽 or maybe keep them as two separate labels?
|
Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to flyteorg/flyte#4140. Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components. |
TL;DR
Automatically adds
base_exec_idlabel with the value of current execution or a previousbase_exec_idif it exists.Reasons:
Type
Are all requirements met?