-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overwriting of cached task outputs for a single execution #minor #616
Overwriting of cached task outputs for a single execution #minor #616
Conversation
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
==========================================
+ Coverage 68.31% 68.38% +0.07%
==========================================
Files 448 449 +1
Lines 10673 10714 +41
Branches 1841 1849 +8
==========================================
+ Hits 7291 7327 +36
- Misses 3382 3387 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
07fd5ae
to
b6a9984
Compare
cc @MorpheusXAUT / @jsonporter any progress on this? |
Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
Allows for stopping docker run via CTRL+C Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
b6a9984
to
e338fa4
Compare
@kumare3 nothing new from my side regarding this PR - just rebased onto current master to resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - nice work!
🎉 This PR is included in version 1.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
TL;DR
Added checkbox to toggle cache overwriting for a single execution.
Type
Are all requirements met?
Complete description
flyteconsole now supports overwriting of cached outputs for a single workflow or task execution. A checkbox was added to the launch/relaunch forms, similar to the interruptible override.
The protobuf timestamp helper changes were added since my local version of latest flyteadmin and flyteconsole seemed to return
number
s instead ofLong
s, causing the UI to error while converting protobuf timestamps. Thus, a simple type check was added - I can revert this if it's not desired/something broken on my local side.As this uses a currently unmergedflyteidl
version, the PR is created as a draft (for review) until a new version offlyteidl
is available.Tracking Issue
flyteorg/flyte#2867
Follow-up issue
NA