Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to universal ISO 8601 date format #848

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bimtauer
Copy link

@bimtauer bimtauer commented Mar 1, 2024

This is an opinionated proposal but please consider it.

Let us try for second to imagine a veil of ignorance behind which we forget all cultural assumptions about date representations. It is our task to determine the logical order in which to arrange a series of containers of varying size without prejudice and with the desire to arrive at the most general solution that could be shown to be derived from first principles.

I believe this is what we would come up with.

Copy link

welcome bot commented Mar 1, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

bimtauer and others added 2 commits March 1, 2024 14:38
Signed-off-by: Tim Bauer <[email protected]>
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.30%. Comparing base (8727951) to head (10a5030).

Files Patch % Lines
packages/oss-console/src/common/formatters.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   55.30%   55.30%           
=======================================
  Files         564      564           
  Lines       14620    14620           
  Branches     2668     2668           
=======================================
  Hits         8085     8085           
  Misses       6535     6535           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Tim Bauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant