Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log-panel): Add a button to show log panel in popup window #857

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MortalHappiness
Copy link
Contributor

TL;DR

Add a button to show log panel in popup window

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

log-popup.mp4

Tracking Issue

Resolves: flyteorg/flyte#5108

Follow-up issue

NA

@MortalHappiness MortalHappiness force-pushed the feature/#5108-log-panel-popup-newtab branch from 88e9f57 to 7a69c70 Compare March 27, 2024 06:06
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 55.30%. Comparing base (7e0f2bd) to head (7a69c70).

❗ Current head 7a69c70 differs from pull request most recent head aebdc40. Consider uploading reports for the commit aebdc40 to get more accurate results

Files Patch % Lines
...cutionDetails/NodeExecutionDetailsPanelContent.tsx 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
+ Coverage   54.74%   55.30%   +0.55%     
==========================================
  Files         578      564      -14     
  Lines       15153    14627     -526     
  Branches     2767     2667     -100     
==========================================
- Hits         8296     8089     -207     
+ Misses       6857     6538     -319     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MortalHappiness MortalHappiness force-pushed the feature/#5108-log-panel-popup-newtab branch from 7a69c70 to aebdc40 Compare April 12, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant