Reuse existing executionClusterLabel value during relaunch #minor #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: va6996 <[email protected]>
Signed-off-by: va6996 <[email protected]>
jsonporter
previously approved these changes
Jul 11, 2024
|
Hey @va6996, sorry for the delay in reviewing your PR; it looks good but there is a minor merge conflict. But its approved now so we can merge it once the conflict is resolved 👍 |
|
@jsonporter could you take a look again? the review got dismissed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Support execution cluster labels in flyteconsole. Additionally, reuse existing executionClusterLabel (if available from workflow execution) value for relaunching workflow/tasks
Type
Are all requirements met?
Complete description
When a user specifies the execution cluster label for a single execution, that information is lost when the user clicks relaunch. This change automatically sets the execution cluster to the value set in the original workflow. Subsequent changes to allow specifying the cluster label via UI can be taken up later.
Tracking Issue
NA
Follow-up issue
NA