Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Add Agent Get Message Proto #440

Closed

Conversation

Future-Outlier
Copy link
Member

TL;DR

As title.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Enable agent to get state message.
For example, agent can return the state message when using the databricks service.

Follow-up issue

flyteorg/flyteplugins#399
flyteorg/flytekit#1834

Signed-off-by: Future Outlier <[email protected]>
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.55% 🎉

Comparison is base (7f62a15) 75.92% compared to head (5c84ed9) 78.48%.

❗ Current head 5c84ed9 differs from pull request most recent head e92256c. Consider uploading reports for the commit e92256c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   75.92%   78.48%   +2.55%     
==========================================
  Files          18       18              
  Lines        1458     1250     -208     
==========================================
- Hits         1107      981     -126     
+ Misses        294      212      -82     
  Partials       57       57              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Future Outlier <[email protected]>
@Future-Outlier
Copy link
Member Author

Please approve it again!
Thanks a lot!

Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Future Outlier added 2 commits September 15, 2023 11:48
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants