added -y option to docker_build.sh. I also fixed a bug on -p option #21
Conversation
|
Thank you for opening this pull request! 🙌 |
| @@ -6,25 +6,35 @@ set -e | |||
| REGISTRY="" | |||
|
|
|||
| # SET the appname here | |||
| PROJECT_NAME="{{ cookiecutter.project_name }}" | |||
| PROJECT_NAME="spx_prediction" | |||
There was a problem hiding this comment.
can we revert this to the cookiecutter variable?
| # convert *.ipynb to *.py | ||
| if hash jupyter 2>/dev/null; then | ||
| echo "Jupyter found. converting workflows/*.ipython to *.py" | ||
| jupyter nbconvert workflows/*.ipynb --to script | ||
| else | ||
| echo "Jupyter not found" | ||
| fi | ||
|
|
||
| # generate requirements.txt if pipenv were used | ||
| if hash pipenv 2>/dev/null;then | ||
| echo "Pipenv found. Generating requirements.txt" | ||
| pipenv run pip freeze > requirements.txt | ||
| else | ||
| echo "Pipenv not found" | ||
| fi |
There was a problem hiding this comment.
this kind of expands the scope and purpose of this docker_build.sh script to be opinionated about jupyter and pipenv as developer tools. I think this would make sense perhaps as part of steps a user manually runs in the README.md instructions.
Thoughts @eapolinario ?
|
also, @masayang would you mind following the instructions here for the DCO tests to pass? https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md |
I had added a couple of features to the sample template. I also fixed a bug in docker_build.sh
pip freeze