Skip to content

Commit

Permalink
Make openai_organization Optional in OpenAI plugins (#2585)
Browse files Browse the repository at this point in the history
* use openai_organization: Optional[str] =  in OpenAI plugins

Signed-off-by: Future-Outlier <[email protected]>

* change default value to None

Signed-off-by: Future-Outlier <[email protected]>

---------

Signed-off-by: Future-Outlier <[email protected]>
  • Loading branch information
Future-Outlier authored Jul 17, 2024
1 parent 785b41c commit 262f6d6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions plugins/flytekit-openai/flytekitplugins/openai/batch/task.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ class BatchEndpointTask(AsyncAgentExecutorMixin, PythonTask):
def __init__(
self,
name: str,
openai_organization: str,
config: Dict[str, Any],
openai_organization: Optional[str] = None,
**kwargs,
):
super().__init__(
Expand Down Expand Up @@ -70,8 +70,8 @@ class OpenAIFileDefaultImages(DefaultImages):

@dataclass
class OpenAIFileConfig:
openai_organization: str
secret: Secret
openai_organization: Optional[str] = None

def _secret_to_dict(self) -> Dict[str, Optional[str]]:
return {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

def create_batch(
name: str,
openai_organization: str,
secret: Secret,
openai_organization: Optional[str] = None,
config: Optional[Dict[str, Any]] = None,
is_json_iterator: bool = True,
file_upload_mem: str = "700Mi",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Any, Dict
from typing import Any, Dict, Optional

from flytekit.configuration import SerializationSettings
from flytekit.core.base_task import PythonTask
Expand All @@ -13,7 +13,7 @@ class ChatGPTTask(SyncAgentExecutorMixin, PythonTask):

_TASK_TYPE = "chatgpt"

def __init__(self, name: str, openai_organization: str, chatgpt_config: Dict[str, Any], **kwargs):
def __init__(self, name: str, chatgpt_config: Dict[str, Any], openai_organization: Optional[str] = None, **kwargs):
"""
Args:
name: Name of this task, should be unique in the project
Expand Down

0 comments on commit 262f6d6

Please sign in to comment.