Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[WIP] Supporting hyperparameter tuining on custom training job task #137

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bnsblue
Copy link
Contributor

@bnsblue bnsblue commented Oct 30, 2020

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

@bnsblue bnsblue changed the title Supporting hyperparameter tuining on custom training job task [WIP] Supporting hyperparameter tuining on custom training job task Oct 30, 2020
@bnsblue bnsblue marked this pull request as draft October 30, 2020 03:38
@codecov-io
Copy link

codecov-io commented Oct 30, 2020

Codecov Report

Merging #137 into master will increase coverage by 0.29%.
The diff coverage is 85.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   61.39%   61.69%   +0.29%     
==========================================
  Files         106      106              
  Lines        5997     6064      +67     
==========================================
+ Hits         3682     3741      +59     
- Misses       1939     1943       +4     
- Partials      376      380       +4     
Impacted Files Coverage Δ
...sks/plugins/k8s/sagemaker/hyperparameter_tuning.go 62.82% <74.64%> (+1.33%) ⬆️
...o/tasks/plugins/k8s/sagemaker/plugin_test_utils.go 94.57% <93.93%> (-0.58%) ⬇️
go/tasks/plugins/k8s/sagemaker/utils.go 69.08% <100.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62036f3...b8dd1bc. Read the comment docs.

@eapolinario
Copy link
Contributor

Moved to flyteorg/flyte#4120

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants