Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add docker credential to databricks job config #364

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Jun 21, 2023

TL;DR

Read the docker username and passport from the secret, and add this credential to the Databricks job config.
https://docs.databricks.com/api/workspace/jobs/create

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

https://flyte-org.slack.com/archives/CP2HDHKE1/p1686928788919089

Follow-up issue

NA

@pingsutw pingsutw marked this pull request as draft June 21, 2023 06:24
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #364 (44f626f) into master (dfdf6f9) will decrease coverage by 0.02%.
The diff coverage is 45.45%.

❗ Current head 44f626f differs from pull request most recent head cbe51c2. Consider uploading reports for the commit cbe51c2 to get more accurate results

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   64.05%   64.04%   -0.02%     
==========================================
  Files         152      152              
  Lines       10392    10400       +8     
==========================================
+ Hits         6657     6661       +4     
- Misses       3124     3126       +2     
- Partials      611      613       +2     
Impacted Files Coverage Δ
go/tasks/plugins/webapi/databricks/plugin.go 65.04% <45.45%> (-0.61%) ⬇️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant