Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Pass location to the BigQuery request #365

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Pass location to the BigQuery request #365

merged 1 commit into from
Jun 27, 2023

Conversation

pingsutw
Copy link
Member

TL;DR

Failed to get the BigQuery job status because we didn't pass the location config to the BibQuery request.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

https://flyte-org.slack.com/archives/CP2HDHKE1/p1683133259253529

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #365 (0d1822a) into master (dfdf6f9) will increase coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 0d1822a differs from pull request most recent head 5429209. Consider uploading reports for the commit 5429209 to get more accurate results

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   64.05%   64.07%   +0.01%     
==========================================
  Files         152      152              
  Lines       10392    10392              
==========================================
+ Hits         6657     6659       +2     
+ Misses       3124     3122       -2     
  Partials      611      611              
Impacted Files Coverage Δ
go/tasks/plugins/webapi/bigquery/plugin.go 67.44% <50.00%> (ø)

... and 1 file with indirect coverage changes

@pingsutw pingsutw merged commit 1d0f3e9 into master Jun 27, 2023
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants