This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Expose NodeId as env var for kubernetes pods #minor #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Keck <[email protected]>
Signed-off-by: Dennis Keck <[email protected]>
fellhorn
force-pushed
the
expose-node-id
branch
from
5751702
to
29abef1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Exposes the NodeId to the kubernetes Pod as environment variable.
Type
Are all requirements met?
Complete description
Currently the environment variables do not provide enough information to know the exact task being executed.
For example we intended to create a unique ID for all retries of a task. Without the nodeID this is not possible as tasks might be reused.
One can retrieve this information also from the hostname but this fails for long names due to k8s pod name length limits.