This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this ID will be a parent / child hierarchy separated by '/' (here). Do we instead want the nodeID to be identical to that displayed in the UI? We could use the
NodeExecutionID.NodeID
and inject here using something likeid.GetID().NodeExecutionId.NodeId
. Thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hamersaw
![image](https://private-user-images.githubusercontent.com/26092524/261047449-f5d4afd9-9a92-43d4-85f4-12e7557f6240.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5Mzk4NDMsIm5iZiI6MTcyNTkzOTU0MywicGF0aCI6Ii8yNjA5MjUyNC8yNjEwNDc0NDktZjVkNGFmZDktOWE5Mi00M2Q0LTg1ZjQtMTJlNzU1N2Y2MjQwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDAzMzkwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkyMDgxYTIzYWM1YTM5ZjFlZGRlYjM0MTJjZGQyMDU2N2VlMDdiMDRiYjljNTAxOTU4YTY5YWE1NjUwNWNlZGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.WIhOImsTuvwUUlMVVOnMO6E88tTATCIgJEZGrRZJMDY)
For our case we need the entire hierarchy, similar to how is is displayed here in the UI:
(ideally without it being shortened to a specific length)
id.GetID().NodeExecutionId.NodeId
only gives me the child nodeID, e.g.dn0
, which might occur multiple times in a workflow. Instead we need the entire hierarchy to uniquely identify a single node in the graph (e.g.n0/dn0/dn0/dn0/dn0
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use something like:
then it should prepend the node ID with the parent info which should give you the
n0-0-dn0
/n0-0-dn0-0-dn0
being separated by-
rather than/
. I think this would be cleaner?