This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Make catalog async client array-aware #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wild-endeavor
approved these changes
Dec 17, 2019
| wi.progress = bitarray.NewBitSet(uint(wi.downloadRequest.Count)) | ||
| } | ||
|
|
||
| isArray := wi.downloadRequest.Count > 0 |
There was a problem hiding this comment.
Can you add a comment for this? Don't understand. We still want the loop to run even if the Count is 0, why? When is the count 0?
| // TODO: size limit is weird to be passed here... | ||
| outputReader = ioutils.NewRemoteFileOutputReader(ctx, wi.request.dataStore, | ||
| ioutils.NewRemoteFileOutputPaths(ctx, wi.request.dataStore, indexedOutputLocation), | ||
| int64(999999999)) |
There was a problem hiding this comment.
Is this in bytes? 953MBs?
katrogan
pushed a commit
that referenced
this pull request
Dec 17, 2019
- in the case when a container exits as success, but writes an error file, we would exit as success. This change actually returns the correct error status
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the way Catalog AsyncClient to natively understand array tasks. The benefits of the change are: