This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Create a FileOutput reader if the agent produce file output #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
==========================================
+ Coverage 63.01% 64.19% +1.17%
==========================================
Files 154 156 +2
Lines 13080 10689 -2391
==========================================
- Hits 8243 6862 -1381
+ Misses 4220 3205 -1015
- Partials 617 622 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
changed the title
8 tasks
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
|
cc @hamersaw would you mind taking a look |
8 tasks
hamersaw
reviewed
Sep 14, 2023
Signed-off-by: Kevin Su <[email protected]>
hamersaw
reviewed
Sep 15, 2023
| } | ||
|
|
||
| if taskTemplate.Interface == nil || taskTemplate.Interface.Outputs == nil || taskTemplate.Interface.Outputs.Variables == nil { | ||
| logger.Infof(ctx, "The task declares no outputs. Skipping writing the outputs.") |
There was a problem hiding this comment.
Can we make this debug too?
Signed-off-by: Kevin Su <[email protected]>
11 tasks
hamersaw
approved these changes
Sep 15, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 28, 2023
Signed-off-by: Kevin Su <[email protected]>
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixed https://flyte-org.slack.com/archives/C05GQ16TQLF/p1692227368597599
Create a
RemoteFileOutputReaderin the agent plugin if the task writes the output to the blob store.For example, an agent may submit a job to aws batch, which will write the output to s3, so we should add a file output reader to task context.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA