Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Make rendering template in agent client temporary #395

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

edwinyyyu
Copy link
Contributor

TL;DR

A render of the task template in the agent client can persist across multiple nodes. Solution stores the unrendered template in a separate variable and uses it to recover the unrendered template.

Type

  • Bug Fix
  • Feature
  • Plugin

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 47.45% and project coverage change: +1.21% 🎉

Comparison is base (13465ae) 63.00% compared to head (942cf2b) 64.22%.
Report is 3 commits behind head on master.

❗ Current head 942cf2b differs from pull request most recent head bf31a53. Consider uploading reports for the commit bf31a53 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   63.00%   64.22%   +1.21%     
==========================================
  Files         154      156       +2     
  Lines       13084    10661    -2423     
==========================================
- Hits         8244     6847    -1397     
+ Misses       4222     3192    -1030     
- Partials      618      622       +4     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
go/tasks/plugins/k8s/kfoperators/common/config.go 0.00% <0.00%> (ø)
...sks/plugins/k8s/kfoperators/common/config_flags.go 17.39% <17.39%> (ø)
go/tasks/plugins/array/awsbatch/transformer.go 81.45% <60.00%> (+2.33%) ⬆️
...o/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go 79.22% <60.00%> (+0.53%) ⬆️
...s/plugins/k8s/kfoperators/tensorflow/tensorflow.go 77.18% <60.00%> (+1.45%) ⬆️
go/tasks/plugins/k8s/kfoperators/mpi/mpi.go 74.49% <66.66%> (+1.92%) ⬆️
.../plugins/k8s/kfoperators/common/common_operator.go 68.45% <100.00%> (+4.13%) ⬆️
go/tasks/plugins/k8s/ray/ray.go 77.56% <100.00%> (-0.71%) ⬇️
go/tasks/plugins/webapi/agent/plugin.go 72.39% <100.00%> (+3.83%) ⬆️

... and 128 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamersaw hamersaw merged commit ff9f55b into flyteorg:master Sep 14, 2023
6 of 7 checks passed
eapolinario pushed a commit that referenced this pull request Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants