Add supportTaskTypes for agentservice without write it in config twice.

[Future-Outlier]

TL;DR

As title.

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

Right now, the agent-service section doesn't need to add supportedTaskTypes anymore.
We can get it by "default-for-task-types" from tasks.

Tracking Issue

flyteorg/flytepropeller#612

[codecov]

Codecov Report

Patch coverage: 60.00% and project coverage change: +1.29% 🎉

Comparison is base (08dd79b) 62.73% compared to head (f9cd2eb) 64.02%.

❗ Current head f9cd2eb differs from pull request most recent head e8e320a. Consider uploading reports for the commit e8e320a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
+ Coverage   62.73%   64.02%   +1.29%     
==========================================
  Files         156      156              
  Lines       13172    10682    -2490     
==========================================
- Hits         8263     6839    -1424     
+ Misses       4284     3218    -1066     
  Partials      625      625              

Flag	Coverage Δ
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
go/tasks/plugins/webapi/agent/config.go	100.00% <ø> (ø)
go/tasks/plugins/webapi/agent/plugin.go	68.71% <60.00%> (+2.81%)	⬆️

... and 135 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[honnix]

I'm not entirely sure this is a good direction to go. As I understood "default-for-task-types" is only needed when there is registration conflict, ie two plugins claiming to support the same type of task. This change to me feels like slightly abusing the semantics of "default-for-task-types". In our production setup for example, we have never needed to use "default-for-task-types", and now with this change we will be forced to use it. This is a breaking change to us.

Besides that, having this type of information scattered in different places of the configuration also doesn't seem to be ideal because it could be easy to miss something.

It would be great if this change can be re-evaluated and reverted. Thank you.

[pingsutw]

As I understood "default-for-task-types" is only needed when there is registration conflict, ie two plugins claiming to support the same type of task

@honnix sorry, This makes sense. We'll revert it shortly.