-
Notifications
You must be signed in to change notification settings - Fork 53
Add supportTaskTypes for agentservice without write it in config twice. #398
Add supportTaskTypes for agentservice without write it in config twice. #398
Conversation
Signed-off-by: Future Outlier <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 62.73% 64.02% +1.29%
==========================================
Files 156 156
Lines 13172 10682 -2490
==========================================
- Hits 8263 6839 -1424
+ Misses 4284 3218 -1066
Partials 625 625
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
… into add-supportedTaskTypes-for-agent-service-by-default-for-task-types
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
…e. (#398) Signed-off-by: Future Outlier <[email protected]> Co-authored-by: Future Outlier <[email protected]>
I'm not entirely sure this is a good direction to go. As I understood "default-for-task-types" is only needed when there is registration conflict, ie two plugins claiming to support the same type of task. This change to me feels like slightly abusing the semantics of "default-for-task-types". In our production setup for example, we have never needed to use "default-for-task-types", and now with this change we will be forced to use it. This is a breaking change to us. Besides that, having this type of information scattered in different places of the configuration also doesn't seem to be ideal because it could be easy to miss something. It would be great if this change can be re-evaluated and reverted. Thank you. |
@honnix sorry, This makes sense. We'll revert it shortly. |
…fig twice. (flyteorg#398)" This reverts commit 2598c96.
…fig twice. (flyteorg#398)" This reverts commit 2598c96. Signed-off-by: Future Outlier <[email protected]>
…fig twice. (#398)" (#412) This reverts commit 2598c96. Signed-off-by: Future Outlier <[email protected]>
TL;DR
As title.
Type
Are all requirements met?
Complete description
Right now, the agent-service section doesn't need to add supportedTaskTypes anymore.
![image](https://private-user-images.githubusercontent.com/76461262/265200568-5e603439-5b15-4fdb-b872-7896ed5e745c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5MzkxMjgsIm5iZiI6MTcyNTkzODgyOCwicGF0aCI6Ii83NjQ2MTI2Mi8yNjUyMDA1NjgtNWU2MDM0MzktNWIxNS00ZmRiLWI4NzItNzg5NmVkNWU3NDVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDAzMjcwOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNiMmI5OWFlNGNmMTNjMmJkMTVlNjhlYzBhM2FjYWUyMGFjN2I4OGQ3ZDMzZGZjMTE3MzIwMTZkY2M0OGEwOTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.tcjCSD9faQMrNXqykZfXxOTUUxfQhqsMkUnkJT1RL5Q)
![image](https://private-user-images.githubusercontent.com/76461262/265200579-3071fb34-9db0-4131-aabb-633f52ff00e2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5MzkxMjgsIm5iZiI6MTcyNTkzODgyOCwicGF0aCI6Ii83NjQ2MTI2Mi8yNjUyMDA1NzktMzA3MWZiMzQtOWRiMC00MTMxLWFhYmItNjMzZjUyZmYwMGUyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDAzMjcwOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU2ZTYyYmQ4MzY5MTU3OGY5MjlkNWEwNjdhZWMwNmViYzllOWVmMTNhODkzM2EzYTY0MjhmNmRmNDFjMWRkZGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.WOcEkmO8r9k39UKm5edKWV3GzFkol5OMkUVA0TMh1z4)
We can get it by "default-for-task-types" from tasks.
Tracking Issue
flyteorg/flytepropeller#612