Fix resources requests for AWS Batch plugin

[hamersaw]

TL;DR

This PR uses the container resources as the base before merging with resource overrides and platform defaults. The logic involved in this PR updated always setting the resource overrides even if there were none (if missing it would set overrides to the container resources), which introduced this regression.

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

flyteorg/flyte#4003

Follow-up issue

NA

[codecov]

Codecov Report

Patch coverage: 60.00% and project coverage change: +1.33% 🎉

Comparison is base (552f145) 62.83% compared to head (34b080c) 64.17%.

❗ Current head 34b080c differs from pull request most recent head 04e363b. Consider uploading reports for the commit 04e363b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
+ Coverage   62.83%   64.17%   +1.33%     
==========================================
  Files         156      156              
  Lines       13116    10647    -2469     
==========================================
- Hits         8242     6833    -1409     
+ Misses       4253     3192    -1061     
- Partials      621      622       +1     

Flag	Coverage Δ
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
go/tasks/plugins/array/awsbatch/transformer.go	81.45% <60.00%> (+2.33%)	⬆️

... and 135 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eapolinario]

Does flyteorg/flytepropeller#544 also affect other plugins?

[hamersaw]

Does flyteorg/flytepropeller#544 also affect other plugins?

Good question, as far as I can tell no. Other plugins use the container parsing we define. AWS Batch is unique because it uses the resources to populate a different object (ie. aws batch job).