Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add ray dashboard log link #405

Merged
merged 7 commits into from
Sep 23, 2023
Merged

Add ray dashboard log link #405

merged 7 commits into from
Sep 23, 2023

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Sep 21, 2023

TL;DR

  • Support configuring Ray Dashboard Links in the Ray Plugin.
  • Add a configuration setting to enable/disable usage metrics collection
  • Fix phase mapping to correctly map RayJob Pending to Initializing (instead of NotReady)

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Tracking Issue

flyteorg/flyte#4063

Signed-off-by: Haytham Abuelfutuh <[email protected]>
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 65.11% and project coverage change: +1.45% 🎉

Comparison is base (08dd79b) 62.73% compared to head (67a4075) 64.19%.
Report is 1 commits behind head on master.

❗ Current head 67a4075 differs from pull request most recent head b591243. Consider uploading reports for the commit b591243 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   62.73%   64.19%   +1.45%     
==========================================
  Files         156      156              
  Lines       13172    10704    -2468     
==========================================
- Hits         8263     6871    -1392     
+ Misses       4284     3202    -1082     
- Partials      625      631       +6     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
go/tasks/pluginmachinery/core/phase.go 21.50% <ø> (-1.27%) ⬇️
go/tasks/plugins/k8s/ray/config.go 36.36% <0.00%> (-13.64%) ⬇️
go/tasks/plugins/webapi/agent/config.go 100.00% <ø> (ø)
go/tasks/plugins/webapi/agent/plugin.go 68.71% <60.00%> (+2.81%) ⬆️
go/tasks/plugins/k8s/ray/ray.go 84.17% <80.00%> (+5.83%) ⬆️
go/tasks/plugins/k8s/ray/config_flags.go 38.70% <100.00%> (+2.34%) ⬆️

... and 132 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
@EngHabu EngHabu marked this pull request as ready for review September 22, 2023 18:37
@EngHabu EngHabu merged commit 8b417f4 into master Sep 23, 2023
6 of 7 checks passed
eapolinario pushed a commit that referenced this pull request Sep 28, 2023
* Add ray dashboard log link

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* A few fixes

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Add EnableUsageStats start parameter

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Add more tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* more tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

---------

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants