Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Revert "deprecated TransitionTypeBarrier (#336)" #408

Closed
wants to merge 1 commit into from

Conversation

hamersaw
Copy link
Contributor

This reverts commit 4f02c2c.

TL;DR

Barriertick is required to ensure correct parallelism and node evaluation during DAG traversal.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (2598c96) 62.73% compared to head (a2c9e50) 64.19%.
Report is 1 commits behind head on master.

❗ Current head a2c9e50 differs from pull request most recent head 1fc603b. Consider uploading reports for the commit 1fc603b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   62.73%   64.19%   +1.45%     
==========================================
  Files         156      156              
  Lines       13173    10704    -2469     
==========================================
- Hits         8264     6871    -1393     
+ Misses       4284     3202    -1082     
- Partials      625      631       +6     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
go/tasks/pluginmachinery/core/phase.go 21.50% <ø> (-1.27%) ⬇️
go/tasks/pluginmachinery/core/transition.go 100.00% <ø> (ø)
go/tasks/plugins/array/k8s/executor.go 40.67% <100.00%> (+1.09%) ⬆️
go/tasks/plugins/k8s/ray/config_flags.go 38.70% <100.00%> (+2.34%) ⬆️
go/tasks/pluginmachinery/internal/webapi/core.go 25.00% <0.00%> (+2.27%) ⬆️
go/tasks/plugins/hive/executor.go 10.12% <0.00%> (+1.87%) ⬆️
go/tasks/plugins/presto/executor.go 11.26% <0.00%> (+1.96%) ⬆️
go/tasks/plugins/k8s/ray/ray.go 84.17% <80.00%> (+5.83%) ⬆️
go/tasks/plugins/k8s/ray/config.go 36.36% <0.00%> (-13.64%) ⬇️

... and 129 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit 4f02c2c.

Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw hamersaw force-pushed the bug/revert-barriertick-removal branch from be58a07 to 1fc603b Compare September 26, 2023 16:49
@hamersaw hamersaw closed this Sep 28, 2023
@hamersaw hamersaw deleted the bug/revert-barriertick-removal branch September 28, 2023 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant