This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Extract CatalogClient from flytepropeller to flytestdlib #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
8 tasks
added 2 commits
January 4, 2023 16:10
Adapted NewClient renaming for catalog client Updated to latest unpublished version of flyteidl, flyteplugins and flytestdlib Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
MorpheusXAUT
force-pushed
the
remove-datacatalog-client
branch
from
03a1381
to
93eb7b4
Compare
|
Rebased onto current |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
The
CatalogClientimplementation has been extracted from flytepropeller's source code and moved to flytestdlib as flyteadmin also needs access to the functionality.Type
Are all requirements met?
Complete description
The whole latest implementation of the catalog package was moved from flytepropeller to flytestdlib since flyteadmin will need access to a client interacting with datacatalog for evicting cached executions.
The PR was created as a draft until the flyteidl, flyteplugins and flytestdlib PRs have been merged and respective versions have been published.
Tracking Issue
flyteorg/flyte#2867
Follow-up issue
NA