Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[Doc] Add Go / dependencies installation instructions #561

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevin85421
Copy link

TL;DR

as title

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

The instructions are similar to: https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md#use-go-v117.

Complete description

as title

Tracking Issue

NA

Follow-up issue

NA

@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Merging #561 (bdadd4c) into master (9a4ea00) will increase coverage by 0.42%.
The diff coverage is n/a.

❗ Current head bdadd4c differs from pull request most recent head c85e57e. Consider uploading reports for the commit c85e57e to get more accurate results

Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Can you use this: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-a-permanent-link-to-a-code-snippet

To reference the current top line of go.mod? In case it changes in the future and we forget to update instructions here?

@kevin85421
Copy link
Author

Hi @EngHabu, thank you for the review! Do you prefer a permanent link or a normal link?

Example:

@EngHabu
Copy link
Contributor

EngHabu commented May 15, 2023

Permanent Link I believe will show if there is a mismatch. What do you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants