Add imageSpec to structured_dataset.py #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
pingsutw
commented
Jul 16, 2024
| @@ -19,10 +19,16 @@ | |||
| from typing_extensions import Annotated | |||
|
|
|||
|
|
|||
| image_spec = ImageSpec( | |||
There was a problem hiding this comment.
It will use the latest flytekit image as default base image.
Signed-off-by: Kevin Su <[email protected]>
andrewwdye
previously approved these changes
Jul 16, 2024
| @@ -18,11 +18,16 @@ | |||
| ) | |||
| from typing_extensions import Annotated | |||
|
|
|||
| image_spec = ImageSpec( | |||
There was a problem hiding this comment.
Any other examples that need updating, or just this one?
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
andrewwdye
previously approved these changes
Jul 17, 2024
Signed-off-by: Kevin Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas,pyarrow,numpyhave been removed from flytekit dependencies, so we should add an ImageSpec to install those dependencies in the image.