This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Deletion of data from storage #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 12, 2022 15:22
Added Delete function to RawStore Implemented deletion for CachedRawStore, MemStore and StowStore Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
MorpheusXAUT
requested review from
EngHabu,
katrogan,
kumare3 and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 68.76% 69.21% +0.45%
==========================================
Files 69 69
Lines 3419 3450 +31
==========================================
+ Hits 2351 2388 +37
+ Misses 909 904 -5
+ Partials 159 158 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
EngHabu
approved these changes
Sep 12, 2022
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Flyte storage has been extended to support deletion of stored data.
Type
Are all requirements met?
Complete description
storage.RawStorenow also has a newDeletemethod, removing the referenced data from the underlying store.CachedRawStore,MemStoreandStowStorehave been extended to support this new functionality.This new functionality is required to remove any no longer present
ArtifactDatain datacatalog while updating artifacts.Tracking Issue
flyteorg/flyte#2867
Follow-up issue
NA