Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

securing global variable using lock #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

securing global variable using lock #61

wants to merge 2 commits into from

Conversation

amitkumarshukla
Copy link
Collaborator

No description provided.

jhakulin
jhakulin reviewed Sep 30, 2021
View reviewed changes
adapters/tlsio_openssl.c
@@ -934,7 +935,14 @@ static int load_cert_crl_http(
goto error;
}

LOCK_RESULT lockResult = Lock(crl_cache_lock);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crl_cache_lock

Just to check is tlsio_openssl_init where the lock is initialzed called before this always ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitkumarshukla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhakulin jhakulin jhakulin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitkumarshukla @jhakulin